Remove pointless indexsets.tabulate parameter include_data
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
- Coverage 87.0% 86.9% -0.1%
=======================================
Files 228 228
Lines 8155 8149 -6
=======================================
- Hits 7095 7089 -6
Misses 1060 1060
|
glatterf42
force-pushed
the
remove/pointless-tabulate-parameter
branch
2 times, most recently
from
50d6fae to
79b2c14
Compare
meksor
approved these changes
Dec 17, 2024
glatterf42
force-pushed
the
remove/pointless-tabulate-parameter
branch
from
79b2c14 to
bc61725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #137: this PR removes the
include_dataparameter, but doesn't add any way to check the length of theindexset.data. For that you still have togettheindexsetsomehow and access the attribute directly.Please note that I did quickly check if including
len(data)would easily be possible. I don't think it is becauseindexset.datais a@propertyon the DB model class at the moment, so not loaded automatically when usingtabulate. That's becausebase.tabulate()usespd.read_sql(), which only reads in the columns of the returned data model (not relationships or attributes built on them).In contrast, e.g.
base.list()returns a list of data models and their attributes can be accessed normally.Thus, it seems to me that there's no quick way to change that for
indexset.tabulate(), though it can definitely be done; either through rewritingbase.tabulate()(think:SELECTall resulting rows first, load their.data, then turn intopd.DataFrame) or by accessing the DB twice (think: usebase.tabulate()as usual, then use e.g.base.list()to get the.datadata and put it into a new column). Neither of those options seems desirable to me at the moment and I don't think it's necessary to comply with themessage_ix` API, so i would ignore that part of #137 for now (at least, if not forever).